Patches item #1043144, was opened at 2004-10-09 01:01 Message generated for change (Comment added) made by ianm74 You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=474853&aid=1043144&group_id=54790
Category: None Group: None >Status: Closed Resolution: None Priority: 5 Submitted By: Ryan Kersh (rpk180) Assigned to: Gert Driesen (drieseng) Summary: vb6task - remove surrounding quotes from conditionals arg Initial Comment: Remove the surrounding quotes from conditionals argument in the vb6task. The arguments seem to be ignored if the surrounding quotes are included. This was a bug in my original patch. ---------------------------------------------------------------------- >Comment By: Ian MacLean (ianm74) Date: 2005-01-01 23:04 Message: Logged In: YES user_id=321872 patch committed and tested - thanks. Sorry for the delay. ---------------------------------------------------------------------- Comment By: Ryan Kersh (rpk180) Date: 2004-11-27 10:35 Message: Logged In: YES user_id=1123207 Gert, The vb6 conditionals attribute does not work at all without this patch (as far as I can tell). We've been using NAntContrib with this patch for a few months now for our vb6 builds and it works great. We use it with multiple conditional arguments and singleton arguments. We've tested this on Windows 2000 and Windows XP. Let me know if you have more questions or if I can help in any way. ---------------------------------------------------------------------- Comment By: Gert Driesen (drieseng) Date: 2004-11-27 03:45 Message: Logged In: YES user_id=707851 Ryan, Are you sure this change is necessary ? I can't test this modification, so I wanna be sure I'm not breaking stuff ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=474853&aid=1043144&group_id=54790 ------------------------------------------------------- The SF.Net email is sponsored by: Beat the post-holiday blues Get a FREE limited edition SourceForge.net t-shirt from ThinkGeek. It's fun and FREE -- well, almost....http://www.thinkgeek.com/sfshirt _______________________________________________ NAntContrib-Developer mailing list NAntContrib-Developer@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nantcontrib-developer