> -----Original Message-----
> From: [EMAIL PROTECTED] 
> [mailto:[EMAIL PROTECTED] On 
> Behalf Of Marcin Hoppe
> Sent: zondag 17 april 2005 14:37
> To: NAntContrib-Developer@lists.sourceforge.net
> Subject: [NAntC-Dev] Subversion tasks quiet attribute and 
> generated output
> 
> Hi!
> 
> I have recently found some time to hack Subversion tasks and followed
> Clayton Harbour's suggestions to add those tasks a feature to save
> their output to some specified file (following <exec> task's
> implementation) and finally implemented the quiet attribute.

I'm not sure if this is really necessary. Users can always use NAntContrib's
<record> task to cpature output of specific tasks to file.

> Things introduced:
>  * AbstractSvnTask.Quiet property added. I have some doubts about this
> idea, because not all Svn commands obey the --quiet parameter (e.g.
> svn log). Nevertheless, <svn-checkout> and <svn-update> do work with
> this parameter.

If not all svn tasks support this attribute, then it does not make sense to
add this to the base class.

>  * The default Quiet attribute value for SvnCheckoutTask and
> SvnUpdateTask is false. I think it makes some sense (previously
> SvnCheckoutTask had this option turned on by default). Now it is more
> consistent. Should it be moved to AbstractSvnTask constructor,
> perhaps?
>  * AbstractSvnTask.Output and AbstractSvnTask.OutputAppend were added
> (both overriding ExternalProgramBase properties). Their implementation
> is directly taken from ExecTask.

Again, not really sure we need this.

Gert



-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
_______________________________________________
NAntContrib-Developer mailing list
NAntContrib-Developer@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nantcontrib-developer

Reply via email to