On 5/30/05, Gert Driesen <[EMAIL PROTECTED]> wrote: > Don't have time to have a close look at your contribution today, but I do > have a few remarks on the <deleteregistry> task (hope you don't mind):
Ok, that's no problem. > - Do we need to be able to specify multiple hives in the "hive" attribute ? It's an little extra benefit that doesn't cost much, both in terms of code complexity and runtime performance. Besides, it works like this in <readregistry> right now. > - Should we add a "value" attribute to allow only a specific value to be > removed ? I've been thinking about it, but there is one thing that makes me worried: in <writeregistry> there is a "value" attribute to specify a string that should be written to the registry. If we make an agreement on do we want it go this way, then your proposal is perfectly fine. My alternative proposal would be: a) in <writeregistry> we preserve "value" with its current meaning, b) in <deleteregistry> we introduce a "valuename" attribute that describes a name of registry value that should be removed. > - Would it be ok to always remove the key and the complete subtree (if no > value is specified) ? If we introduce a "valuename" attribute or something similar, then it's perfectly fine to implement it this way. I will also refactor this code a little bit and probably extract an abstract AbstractRegistryTask. Amount of redundant code makes it a reasonable idea, IMHO. What do you think about it? Best regards! Marcin ------------------------------------------------------- This SF.Net email is sponsored by Yahoo. Introducing Yahoo! Search Developer Network - Create apps using Yahoo! Search APIs Find out how you can build Yahoo! directly into your own Applications - visit http://developer.yahoo.net/?fr=offad-ysdn-ostg-q22005 _______________________________________________ NAntContrib-Developer mailing list NAntContrib-Developer@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nantcontrib-developer
