+1. 

A comment above the line

+            final boolean failDelete = strictMode || (!symbol.isScope() && 
(symbol.isParam() || (symbol.isVar() && !symbol.isProgramLevel())));

explaining the logic, would be helpful, I guess. It is getting a bit convoluted.


Can you add a TODO in the comment in LocalVariableTypesCalculator so it shows 
up in the margin of IDEs? 

On 23 Jun 2014, at 14:20, A. Sundararajan 
<[email protected]> wrote:

> Please review http://cr.openjdk.java.net/~sundar/8047728/
> 
> Thanks
> -Sundar

Reply via email to