Actually after rerunning 100 times, I think the changed speed is already inside the standard deviation. It appears that both constructors to UOE and RewriteException already pass the “writableStackTrace” parameter as false if we are not running in debug mode. I understand that this is equivalent to overriding fillInStackTrace, right ?
/M On 26 Sep 2014, at 13:00, Aleksey Shipilev <[email protected]> wrote: > On 09/26/2014 02:59 PM, Aleksey Shipilev wrote: >> On 09/26/2014 02:52 PM, Marcus Lagergren wrote: >>> Very small fix that removes fillInStackTrace from >>> UnwarrantedOptimismException and RewriteException. All tests pass. This >>> buys us a few single digit percent on avatar startup with Optimistic Types >>> >>> Webrev at: http://cr.openjdk.java.net/~lagergren/8059123/webrev/ >> >> Drop the "synchronized" as well then. > > This applies to all another places where we have stackless exceptions as > well... > > -Aleksey. > >
