There are various indentation errors in the test classes. And since this is for JDK9, help text for --optimstic-types should not say "Optimistic typing is currently disabled by default".

Apart from that +1.

Hannes

Am 2014-10-08 um 18:16 schrieb Marcus Lagergren:
This is

1) Optimistic types moving to a documented option in jjs -help
2) Optimistic types being default off for 8u40 (it is still left on in this 
that goes into 9 - will flip the flag at backport)
3) Support for testing in both optimistic and non optimistic mode for all the 
unit tests with ‘ant test’. This will be live in both 8u40 and 9 (but with 
different defaults - same tests though) to avoid bit rot of the non-optimistic 
functionality as long as it exists.

Please give me reviews. Ant test passes with both configurations after Hannes 
fixing JDK-8059938

The webrev is here: http://cr.openjdk.java.net/~lagergren/8059811.3/

/M


Reply via email to