+1 with some very small nitpicks:
1) There’s a "+ System.out.println("HEEH =? " + e);”
left in the web rev. Remove that
2) Please add curly braces around
40 for (var j = 0; j < 64; ++j)
41 arr[j] = new Random();
to avoid future “ssl library goto end bugs” if someone adds a statement and
forgets it. I think it’s our code convention
3) When you did lazy initialisation in Global.java, there appeared a lot of
Javadoc warnings for public methods that you added. Can you as part of this, or
any future change, when convenient, add javadoc comments for these?
Regards
Marcus
> On 13 May 2015, at 06:35, A. Sundararajan
> <[email protected]> wrote:
>
> Please review http://cr.openjdk.java.net/~sundar/8080182/ for
> https://bugs.openjdk.java.net/browse/JDK-8080182
>
> Thanks,
> -Sundar
