Thanks.
PS. Uploaded updated webrev :
http://cr.openjdk.java.net/~sundar/8098578/webrev.02/ of changes that
I'll push.
-Sundar
On Tuesday 16 June 2015 06:19 PM, Attila Szegedi wrote:
+ assert ((ScriptObject)scope).isGlobal() : "non-Global scope
object!!";
+ final ScriptObject sobj = (ScriptObject)scope;
You could swap these two lines and use "sobj" in assert.
+1 otherwise; it’s okay from me to push after these changes.
Attila.
On Jun 16, 2015, at 2:27 PM, A. Sundararajan
<sundararajan.athijegannat...@oracle.com> wrote:
Please review updated http://cr.openjdk.java.net/~sundar/8098578/webrev.01/
Fixed comments per internal suggestions (updated in bug report) and also using
newScope() to be able to handle large script with indirect load call.
Thanks,
-Sundar
On Tuesday 16 June 2015 12:41 PM, A. Sundararajan wrote:
Please review http://cr.openjdk.java.net/~sundar/8098578/ for
https://bugs.openjdk.java.net/browse/JDK-8098578
-Sundar
