Looks good, +1
> On Jun 18, 2015, at 2:57 PM, A. Sundararajan
> <sundararajan.athijegannat...@oracle.com> wrote:
>
> Hi,
>
> Please review updated review
> http://cr.openjdk.java.net/~sundar/8117883/webrev.01/
>
> PS. Fixed for what Ahmed found in his previous email as well as cleanup other
> things (like not adding CONSTRUCTOR, SPECIALIZED_FUNCTION (constructor) as
> members for Constructor class) etc.
>
> Thanks,
> -Sundar
>
> On Thursday 18 June 2015 11:57 AM, Ahmed Ashour wrote:
>> Hi Sundar,
>> PropertyGenerator is ok, but ConstructorGenerator still has the issue.
>> For example:
>> NativeArray:
>> static { ArrayList list = new ArrayList(7);
>> list.add(AccessorProperty.create("isArray", 2, "G$isArray", "S$isArray"));
>> $nasgenmap$ = PropertyMap.newMap(list); }
>> because ScriptClassInfo.getConstructorMemberCount() returns also
>> Kind.CONSTRUCTOR and .SPECIALIZED_FUNCTION, which are not 'added'.
>> Thanks a lot,Ahmed From: Ahmed Ashour <asash...@yahoo.com>
>> To: A. Sundararajan <sundararajan.athijegannat...@oracle.com>;
>> "nashorn-dev@openjdk.java.net" <nashorn-dev@openjdk.java.net>
>> Sent: Wednesday, June 17, 2015 9:41 PM
>> Subject: Re: RFR 8117883: nasgen prototype, instance member count
>> calculation is wrong
>> Hi Sundar,
>> Works great, thanks for the quick response.
>> I don't fully understand the removal of ScriptObject.isGenericDescriptor
>> I guess users are not allowed to be created in bugs.openjdk.java.net.
>> Thanks again,Ahmed
>>
>> From: A. Sundararajan <sundararajan.athijegannat...@oracle.com>
>> To: "nashorn-dev@openjdk.java.net" <nashorn-dev@openjdk.java.net>
>> Sent: Wednesday, June 17, 2015 7:20 PM
>> Subject: RFR 8117883: nasgen prototype, instance member count calculation
>> is wrong
>> Please review http://cr.openjdk.java.net/~sundar/8117883/ for
>> https://bugs.openjdk.java.net/browse/JDK-8117883
>>
>> Thanks,
>> -Sundar
>>
>>
>>
>>
>
