+1
-Sundar
On Thursday 02 July 2015 02:48 PM, Michael Haupt wrote:
Hi Sundar,
thanks, of course that's right. The updated webrev at
http://cr.openjdk.java.net/~mhaupt/8130307/webrev.01 addresses this and
generates Javadoc for all of Nashorn.
Best,
Michael
Am 02.07.2015 um 11:15 schrieb A. Sundararajan
<[email protected]>:
Actually, I forgot to mention. "javadocapi" results in docs being generated only for
jdk.nashorn.api.* classes - whereas javadoc generates docs for all nashorn classes - including
jdk.nashorn.internal.*. Yes, asm dependency is a problem - but if we leave jdk.nashorn.internal.*
classes, then nashorn developers may accidentally slip in wrong javadoc comments ( unescaped entities
like "<", missing @param/@result etc.). So it's better to have test dependent on javadoc
target.
PS. It'd be great if we can avoid "asm" - but still generate nashorn (full)
javadoc.
-Sundar
On Thursday 02 July 2015 02:39 PM, A. Sundararajan wrote:
+1
-Sundar
On Thursday 02 July 2015 02:26 PM, Michael Haupt wrote:
Dear all,
please review and sponsor this change:
RFE: https://bugs.openjdk.java.net/browse/JDK-8130307
Webrev: http://cr.openjdk.java.net/~mhaupt/8130307/webrev.00
This removes the ASM Javadoc dependency from the "ant test" task (it is still
possible to generate ASM Javadoc), and does away with a long command line problem that
would occur on Windows.
Thanks,
Michael
