Hi,
Comments below..
On Tuesday 07 July 2015 04:18 PM, Michael Haupt wrote:
Hi Sundar,
this is a lower-case review with two minor remarks for Global.java:
* in the first chunk, the comment above the deleted line for LAZY_SENTINEL can
go away as well
Will remove that comment.
* in the last chunk, how about renaming isLocationPropertyPlaceholder() to
isUninitialized()?
Actually, same internal value is used for "uninitialized" state and as
"location placeholder". i.e., leaving external query methods "as is" and
just reusing same internal "flag value" for two purposes.
Thanks
-Sundar
Otherwise, nothing to add. :-)
Best,
Michael
Am 07.07.2015 um 12:30 schrieb A. Sundararajan
<sundararajan.athijegannat...@oracle.com>:
Please review http://cr.openjdk.java.net/~sundar/8130663/ for
https://bugs.openjdk.java.net/browse/JDK-8130663
- made 6 fields as static in Global.java
- using lazy init sentinel as location placebolder as well
- few other simple code cleanups.
Thanks,
-Sundar
