Hi Sundar,

> Am 08.07.2015 um 11:11 schrieb A. Sundararajan 
> <[email protected]>:
> Please review http://cr.openjdk.java.net/~sundar/8130734/ for 
> https://bugs.openjdk.java.net/browse/JDK-8130734

lower-case review: there is a number of fields that are now public static 
final, but which have camelCase names. These could be renamed to UPPER_CASE 
names.

* MemberInfo.myLoader
* ScriptEngineTest.propNames
* AbstractScriptRunnable.evaluators
* PropertyBind.staticReadOnly

Otherwise, no remarks. :-)

Best,

Michael

-- 

 <http://www.oracle.com/>
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG, Schiffbauergasse 14 | 14467 Potsdam, Germany
 <http://www.oracle.com/commitment>     Oracle is committed to developing 
practices and products that help protect the environment

Reply via email to