Hi Hannes,

> Am 17.07.2015 um 12:27 schrieb Hannes Wallnoefer 
> <[email protected]>:
> Please review JDK-8131340: Varargs function is recompiled each time it is 
> linked
> 
> http://cr.openjdk.java.net/~hannesw/8131340/


lower-case thumbs up, with one remark: getBest is now defined in SFD and 
overridden in RecompSFD, and the super call is gone, so the implementation of 
getBest in SFD is now only responsible for FinalSFD only - how about making it 
abstract in SFD and moving the implementation to FinalSFD?

Best,

Michael

-- 

 <http://www.oracle.com/>
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG, Schiffbauergasse 14 | 14467 Potsdam, Germany
 <http://www.oracle.com/commitment>     Oracle is committed to developing 
practices and products that help protect the environment

Reply via email to