you have some "final"s missing from parameters (Console constructor and Completer.complete). Other than that, looks good. Took me a bit to understand, but I like it. It seems like a quite nice functionality with not much code needed!
Attila. > On Aug 17, 2015, at 8:04 AM, Sundararajan Athijegannathan > <[email protected]> wrote: > > Hi, > > I've updated the webrev to avoid tab-completing in the middle of expression > and also to handle embedded member selection expressions (in other binary, > unary, assignment expressions...). > > Please review the updated nashorn webrev at: > > http://cr.openjdk.java.net/~sundar/8133652/nashorn/webrev.01/ > > Thanks, > -Sundar > > On 8/14/2015 6:20 PM, Jim Laskey (Oracle) wrote: >> +1 >> >>> On Aug 14, 2015, at 9:45 AM, Sundararajan Athijegannathan >>> <[email protected]> wrote: >>> >>> Please review http://cr.openjdk.java.net/~sundar/8133652/ for >>> https://bugs.openjdk.java.net/browse/JDK-8133652 >>> >>> Thanks, >>> -Sundar >
