... oh, other than that: lower-case thumbs up.

Michael

> Am 02.09.2015 um 13:15 schrieb Michael Haupt <[email protected]>:
> 
> Hi Sundar,
> 
> with any particular TypeMap instance hanging off of a node, and all of its 
> members constant, I think some of the logic throughout the class can be 
> reduced by means of constant folding. For instance, getCallSiteType() doesn't 
> really have to do the appendParameterTypes() sequence every time. The result 
> could be computed once and cached. Likewise for other methods.
> 
> Best,
> 
> Michael
> 
>> Am 02.09.2015 um 13:00 schrieb Sundararajan Athijegannathan 
>> <[email protected]>:
>> 
>> Please review http://cr.openjdk.java.net/~sundar/8134931/ for 
>> https://bugs.openjdk.java.net/browse/JDK-8134931
>> 
>> Thanks,
>> -Sundar

-- 

 <http://www.oracle.com/>
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG, Schiffbauergasse 14 | 14467 Potsdam, Germany
 <http://www.oracle.com/commitment>     Oracle is committed to developing 
practices and products that help protect the environment

Reply via email to