Hi Sundar, lower-case thumbs up!
Best, Michael > Am 03.09.2015 um 17:44 schrieb Sundararajan Athijegannathan > <[email protected]>: > > Updated webrev: http://cr.openjdk.java.net/~sundar/8087292/webrev.01/ > > Updates: > > * Added throwOnError property (false default) to $EXEC function object > * Added a test case (suggested by Michael offline) > > On RangeError: I interpreted as { 0 } as only "expected" set of exit code > values. Anything outside that is a "range error" as /RangeError/ object > indicates an error when a value is not in the set or range of allowed values > > Thanks, > -Sundar > > On 9/3/2015 7:07 PM, Hannes Wallnoefer wrote: >> Two suggestions: >> >> The return code is just the "messenger" and we don't know what went wrong, >> so I would prefer to use plain Error instead of RangeError. >> And maybe we could set $EXEC.throwOnError = false by default so this feature >> was easier to discover. >> >> Hannes >> >> Am 2015-09-03 um 15:33 schrieb Sundararajan Athijegannathan: >>> Please review http://cr.openjdk.java.net/~sundar/8087292/ for >>> https://bugs.openjdk.java.net/browse/JDK-8087292 >>> >>> Thanks, >>> -Sundar >> > -- <http://www.oracle.com/> Dr. Michael Haupt | Principal Member of Technical Staff Phone: +49 331 200 7277 | Fax: +49 331 200 7561 Oracle Java Platform Group | LangTools Team | Nashorn Oracle Deutschland B.V. & Co. KG, Schiffbauergasse 14 | 14467 Potsdam, Germany <http://www.oracle.com/commitment> Oracle is committed to developing practices and products that help protect the environment
