Great work! I’m very happy that ScriptFunctionImpl is going away.
Some implementation remarks:
- The newly public methods in Global.java, getFunctionPrototype and
getTypeErrorThrower don’t have Javadoc.
- The newly public two constructors of PrototypeObject also don’t hava Javadoc.
- while you're at it, how about we replace
ScriptFunction.constructorCount/invokes/allocations fields with LongAdder
objects? We should gradually be replacing all such static counters.
- can we create an explicit subclass for bound functions? It can be declared as
"private static class Bound extends ScriptFunction { ... }" within the
ScriptFunction class. When we debug, we'll then see its name as
ScriptFunction$Bound instead of ScriptFunction$1.
Attila.
> On Sep 9, 2015, at 10:19 AM, Sundararajan Athijegannathan
> <[email protected]> wrote:
>
> Please review http://cr.openjdk.java.net/~sundar/8027137/ for
> https://bugs.openjdk.java.net/browse/JDK-8027137
>
> Thanks,
> -Sundar
