... small correction: in Parser.java, "any of it's element" should be "any of 
its elements".

Best,

Michael

> Am 11.09.2015 um 10:28 schrieb Michael Haupt <michael.ha...@oracle.com>:
> 
> Hi Sundar,
> 
> lower-case thumbs up!
> 
> Best,
> 
> Michael
> 
>> Am 11.09.2015 um 09:52 schrieb Sundararajan Athijegannathan 
>> <sundararajan.athijegannat...@oracle.com>:
>> 
>> Please review http://cr.openjdk.java.net/~sundar/8136349/ for 
>> https://bugs.openjdk.java.net/browse/JDK-8136349
>> 
>> This is a contribution by Ahmed Ashour. Please see this thread -> 
>> http://mail.openjdk.java.net/pipermail/nashorn-dev/2015-September/005206.html
>> 
>> This webrev was generated by after applying Ahmed's patch & then fixing the 
>> following manually on top of that:
>> 
>> 1) File: NativeRegExp.java
>> 
>>   preceds -> precedes
>> 
>> 2) File: CompiledFunction.java
>> 
>>   rest of -> "restOf" - this is a reference to "restOf" methods generated 
>> and so should not be "rest of".
>> 
>> Thanks,
>> -Sundar


-- 

 <http://www.oracle.com/>
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG, Schiffbauergasse 14 | 14467 Potsdam, Germany
 <http://www.oracle.com/commitment>     Oracle is committed to developing 
practices and products that help protect the environment

Reply via email to