Hi Sundar, lower-case thumbs up.
One remark: I'm a bit concerned about the plethora of files involved with the dynalink samples. For each particular sample, there's a Java file, a sample JS file, and a linker JS file, where the linker compiles the Java file and assembles a JAR. The linkers all look pretty much the same. In my opinion, providing one script that takes care of compilation and JARring and is loaded from all actual samples would keep the samples more lean. Best, Michael > Am 09.12.2015 um 08:56 schrieb Sundararajan Athijegannathan > <sundararajan.athijegannat...@oracle.com>: > > Please review http://cr.openjdk.java.net/~sundar/8144979/ for > https://bugs.openjdk.java.net/browse/JDK-8144979 > This fix is already in jake/nashorn. See also: > https://bugs.openjdk.java.net/browse/JDK-8144568 > > In addition, I've moved all dynalink samples to $nashorn/samples/dynalink > directory and renamed the README. > > Thanks, > -Sundar -- <http://www.oracle.com/> Dr. Michael Haupt | Principal Member of Technical Staff Phone: +49 331 200 7277 | Fax: +49 331 200 7561 Oracle Java Platform Group | LangTools Team | Nashorn Oracle Deutschland B.V. & Co. KG, Schiffbauergasse 14 | 14467 Potsdam, Germany <http://www.oracle.com/commitment> Oracle is committed to developing practices and products that help protect the environment
