Hi Srinivas, > Am 29.02.2016 um 17:28 schrieb Srinivas Dama <srinivas.d...@oracle.com>: > Please review : > Bug : https://bugs.openjdk.java.net/browse/JDK-8138906 > Webrev : http://cr.openjdk.java.net/~sdama/8138906/webrev.01
I've verified this works on Windows. Lower-case thumbs up, with these remarks: == JDK-util.js == Lines 64/65: typos, please use "Unix cygpath implementation. Supports only two outputs, windows (C:\dir\) and mixed (C:/dir/)." == JDK-8087292.js == Copyright: convention requires a space after the comma in "2015,2016", and a comma after "2016", i.e., please use "2015, 2016, ". As a matter of personal preference, how about using semicolons consistently, i.e., either at the ends of all lines, or never? > I have added some utility functions(can be added more) which can be used in > all nashorn test case to make them work > Independent of underlying shell.(removed dependency on shell commands like : > which) These look useful and should be adopted by more tests (that's a future RFE). Best, Michael -- <http://www.oracle.com/> Dr. Michael Haupt | Principal Member of Technical Staff Phone: +49 331 200 7277 | Fax: +49 331 200 7561 Oracle Java Platform Group | LangTools Team | Nashorn Oracle Deutschland B.V. & Co. KG | Schiffbauergasse 14 | 14467 Potsdam, Germany ORACLE Deutschland B.V. & Co. KG | Hauptverwaltung: Riesstraße 25, D-80992 München Registergericht: Amtsgericht München, HRA 95603 Komplementärin: ORACLE Deutschland Verwaltung B.V. | Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister der Handelskammer Midden-Nederland, Nr. 30143697 Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher <http://www.oracle.com/commitment> Oracle is committed to developing practices and products that help protect the environment
