Hi Michael,
Looks good.
Few limitations with absolute paths.
On cmd.exe:
jjs -scripting
$EXEC("D:\work\nashorn-dev\dev\build\windows-x86_64-normal-server-release\images\jdk\bin\java.exe")
Good thing is on cygwin if we give mixed path like:
$EXEC("D:/work/nashorn-dev/dev/build/windows-x86_64-normal-server-release/images/jdk/bin/java.exe"),it
works.
But
$EXEC("/cygdrive/d/work/nashorn-dev/dev/build/windows-x86_64-normal-server-release/images/jdk/bin/java.exe")
fails.
So if we handle only cmd.exe is enough I guess.
Absolute paths should be handled because many test cases pass absolute paths
taken from JAVA_HOME.
Regards,
Srinivas
-----Original Message-----
From: Michael Haupt
Sent: Monday, March 07, 2016 5:58 PM
To: Nashorn-dev
Subject: RFR(S): 8151291: $EXEC yields "unknown command" on Cygwin
Dear all,
please review this change.
Bug: https://bugs.openjdk.java.net/browse/JDK-8151291
Webrev: http://cr.openjdk.java.net/~mhaupt/8151291/webrev.00/
For Cygwin, paths need special attention as the /cygdrive/x/... format is not
recognised by Windows.
Thanks,
Michael
--
<http://www.oracle.com/>
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561 Oracle Java Platform Group |
LangTools Team | Nashorn Oracle Deutschland B.V. & Co. KG | Schiffbauergasse 14
| 14467 Potsdam, Germany
ORACLE Deutschland B.V. & Co. KG | Hauptverwaltung: Riesstraße 25, D-80992
München
Registergericht: Amtsgericht München, HRA 95603
Komplementärin: ORACLE Deutschland Verwaltung B.V. | Hertogswetering 163/167,
3543 AS Utrecht, Niederlande Handelsregister der Handelskammer
Midden-Nederland, Nr. 30143697
Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher
<http://www.oracle.com/commitment> Oracle is committed to developing
practices and products that help protect the environment
