Hi Hannes,
that's a really significant improvement, thanks for taking this on!
There is one thing that I think needs to be addressed. Several occurrences of
throw error(...) pass a plain English string, rather than passing the result of
a call to AbstractParser.message(...), which stands in the path of message
internationalisation. Some invocations of String.format() in this setting pass
only a String but no arguments (these will go away automatically when the
messages are converted to retrieval).
Nits:
* Block.java - this (in the first chunk) can go away, or should not be
commented out:
+ // assert start <= finish;
* Parser.java - the label here should be indented:
+ private void statementList() {
+ // Accumulate statements until end of list. */
+loop:
+ while (type != EOF) {
+ switch (type) {
+ case EOF:
Best,
Michael
> Am 25.04.2016 um 13:49 schrieb Hannes Wallnoefer
> <hannes.wallnoe...@oracle.com>:
>
> Please review JDK-8134503: support ES6 parsing in Nashorn
>
> http://cr.openjdk.java.net/~hannesw/8134503/webrev/
>
> The original patch was contributed by Andreas Woess, I just did the
> integration into Nashorn tip.
>
> Thanks,
> Hannes
--
<http://www.oracle.com/>
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG | Schiffbauergasse 14 | 14467 Potsdam, Germany
ORACLE Deutschland B.V. & Co. KG | Hauptverwaltung: Riesstraße 25, D-80992
München
Registergericht: Amtsgericht München, HRA 95603
Komplementärin: ORACLE Deutschland Verwaltung B.V. | Hertogswetering 163/167,
3543 AS Utrecht, Niederlande
Handelsregister der Handelskammer Midden-Nederland, Nr. 30143697
Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher
<http://www.oracle.com/commitment> Oracle is committed to developing
practices and products that help protect the environment
