On 30/05/2016 11:43, Sundararajan Athijegannathan wrote:
Updated nashorn webrev:
http://cr.openjdk.java.net/~sundar/8158131/nashorn/webrev.01/

* Added @link in ModuleGraphManipulator.java's javadoc

* Using Context.class.getModule() in all places where nashorn module is
needed

* Using  all caps names for static final variables  - nashornModule,
javaBaseModule, myModule  in generated


I looked over the changes and good to see it using the API to create dynamic modules. I assume folks familiar with the Nashorn code will do the detailed review.

-Alan

Reply via email to