Hi Michael,
Thank you for comments . Please find patch with your suggestions added at http://cr.openjdk.java.net/~sdama/8160801/webrev.00/ Regards, Srinivas From: Michael Haupt Sent: Tuesday, July 26, 2016 6:06 PM To: Srinivas Dama Cc: Nashorn-dev Subject: Re: RFR 8160801 :add documentation for NativeString Hi Srini, thumbs up, with conditions (see below). I'll be happy to sponsor the push. +String.prototype.concat=returns string value which is mix of calling object string value and string value given as argument A mix would be fun. :-) How about this: returns the string resulting from appending the argument string value to the calling object +String.prototype.indexOf=returns the index of first occurrence of specified string, starting the search from position given as argument.returns -1 if the string is not found + +String.prototype.lastIndexOf=returns the index of last occurrence of specified string, searching backwards from position given as argument.returns -1 if the string is not found Please replace ".returns" with ", returns" (note the extra space). Best, Michael Am 26.07.2016 um 13:57 schrieb Srinivas Dama <HYPERLINK "mailto:srinivas.d...@oracle.com"srinivas.d...@oracle.com>: Hello, Please review http://cr.openjdk.java.net/~sdama/8160801/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8160801 Regards, Srinivas -- HYPERLINK "http://www.oracle.com/" \nOracle Dr. Michael Haupt | Principal Member of Technical Staff Phone: +49 331 200 7277 | Fax: +49 331 200 7561 Oracle Java Platform Group | LangTools Team | Nashorn Oracle Deutschland B.V. & Co. KG | Schiffbauergasse 14 | 14467 Potsdam, Germany ORACLE Deutschland B.V. & Co. KG | Hauptverwaltung: Riesstraße 25, D-80992 München Registergericht: Amtsgericht München, HRA 95603 Komplementärin: ORACLE Deutschland Verwaltung B.V. | Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister der Handelskammer Midden-Nederland, Nr. 30143697 Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher HYPERLINK "http://www.oracle.com/commitment" \nGreen Oracle Oracle is committed to developing practices and products that help protect the environment