This change conflicts with Attila’s add-finals change in Parser.java. I uploaded a new webrev with the merged patch. I double-checked that it keeps the finals and that the code I added uses final too.
http://cr.openjdk.java.net/~hannesw/8167289/webrev.01/ Hannes > Am 07.10.2016 um 05:27 schrieb Sundararajan Athijegannathan > <sundararajan.athijegannat...@oracle.com>: > > +1 > > -Sundar > > > On 10/6/2016 8:21 PM, Hannes Wallnöfer wrote: >> Please review: >> >> Bug: https://bugs.openjdk.java.net/browse/JDK-8167289 >> Webrev: http://cr.openjdk.java.net/~hannesw/8167289/webrev.00/ >> >> These is mostly refactoring Andreas did in the Graal.js parser. It also >> contains minor ES6 parsing fixes. Tests for these will be included together >> with other additional ES6 tests I’m working on, but I wanted to do a >> separate commit for the backport, so this issue is labeled noreg-cleanup. >> >> Thanks, >> Hannes >
