Thank you Hannes for the comments.

Here is the revised patch at 
http://cr.openjdk.java.net/~sdama/8184720/webrev.01/ .

Note: This includes additional fix from Hannes on top of existing fix to 
resolve assertion error while
running tests from 'ant' test runner without 'scripting' option.

Regards,
Srinivas

-----Original Message-----
From: Hannes Wallnöfer 
Sent: Wednesday, August 23, 2017 12:15 PM
To: Srinivas Dama
Cc: Nashorn-Dev
Subject: Re: RFR: 8184720(Nashorn engine in strict mode throws a 
java.lang.ClassCastException when calling apply() and passing the arguments 
object)

Hi Srini,

I don’t think the -scripting option is needed in the test, and you could just 
call the function without try-catch and printing messages.

Otherwise +1

Hannes


> Am 23.08.2017 um 06:38 schrieb Srinivas Dama <srinivas.d...@oracle.com>:
> 
> Hi,
> 
> Please review http://cr.openjdk.java.net/~sdama/8184720/webrev.00/ for 
> https://bugs.openjdk.java.net/browse/JDK-8184720 
> 
> Regards,
> Srinivas

Reply via email to