Hi, Please review revised patch after migrating to jdk10/master repo. http://cr.openjdk.java.net/~sdama/8185257/webrev.02/
Regards, Srinivas -----Original Message----- From: Hannes Wallnöfer Sent: Wednesday, September 13, 2017 1:49 AM To: Srinivas Dama Cc: Nashorn-dev Subject: Re: RFR: 8185257(Nashorn AST is missing nodes when a for-loop contains a VariableDeclarationList) +1 Hannes > Am 12.09.2017 um 19:38 schrieb Sundararajan Athijegannathan > <sundararajan.athijegannat...@oracle.com>: > > +1 > > -Sundar > > On 12/09/17, 11:02 PM, Srinivas Dama wrote: >> Thank you for the comments sundar. >> >> Here is the revised patch with test case modified. >> http://cr.openjdk.java.net/~sdama/8185257/webrev.01/ >> >> Regards, >> Srinivas >> ----- Original Message ----- >> From: sundararajan.athijegannat...@oracle.com >> To: nashorn-dev@openjdk.java.net >> Sent: Tuesday, September 12, 2017 6:49:09 PM GMT +05:30 Chennai, >> Kolkata, Mumbai, New Delhi >> Subject: Re: RFR: 8185257(Nashorn AST is missing nodes when a >> for-loop contains a VariableDeclarationList) >> >> You may want to print Tree kind in the test rather than using >> implementation class name (and using that it .EXPECTED file). >> >> Other than that, +1 >> >> -Sundar >> >> On 12/09/17, 4:58 PM, Srinivas Dama wrote: >>> Please review http://cr.openjdk.java.net/~sdama/8185257/webrev.00/ >>> for https://bugs.openjdk.java.net/browse/JDK-8185257 >>> >>> Regards, >>> Srinivas
