Hi Hannes,
Thanks for the comment, updated webrev:
http://cr.openjdk.java.net/~jlahoda/8203814/webrev.01/
(It also includes a few more tweaks that turned out to be needed.)
Jan
On 15.6.2018 16:52, Hannes Wallnöfer wrote:
Thanks for helping out with this, Jan.
Unfortunately I found another change that was backported to 8u102 that changes
the signatures of ScriptUtils makeSynchronizedFunction(…) and wrap(…) methods
(again).
https://bugs.openjdk.java.net/browse/JDK-8148379
I’m sorry about this, I should have checked when you first asked me about it.
Otherwise the patch looks good to me.
Hannes
Am 15.06.2018 um 15:47 schrieb Jan Lahoda <jan.lah...@oracle.com>:
Hi,
The Nashorn APIs have been enhanced in JDK 8 updates. The proposal here is to
update the historical data for --release 8 to JDK 8u40.
Note this includes removal of:
jdk.nashorn.api.scripting.NashornException.ENGINE_SCRIPT_SOURCE_NAME
and:
jdk.nashorn.api.scripting.NashornScriptEngine.__noSuchProperty__(...)
and a change of:
jdk.nashorn.api.scripting.ScriptUtils.wrap(...)
Bug: https://bugs.openjdk.java.net/browse/JDK-8203814
Webrev: http://cr.openjdk.java.net/~jlahoda/8203814/webrev.00/
How does this look?
Thanks,
Jan
