On Wed, 2005-09-14 at 11:12 +0200, Christian Neumair wrote:
> Am Mittwoch, den 14.09.2005, 01:21 +0200 schrieb Christian Neumair:
> > The attached patch fixes bug 314730 [1] and a potential leak, since the
> > user variable was not freed if the preceding if branch wasn't reached.
> > Also, passing free'd pointers to g_strconcat is no good.
> >
> > Sidenote: According to the GnomeVFS SMB-Method code, the domain/user
> > will be figured out correctly even if user is "".
>
> By 'if user is ""' I mean the value of the user entry.
>
> The last patch potentially introduced a new crasher variant by always
> freeing the previous user variable.
> New patch attached.
>
> > [1] http://bugzilla.gnome.org/show_bug.cgi?id=314730
Looks good. Please commit.
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
Alexander Larsson Red Hat, Inc
[EMAIL PROTECTED] [EMAIL PROTECTED]
He's a time-tossed drug-addicted barbarian who hides his scarred face behind a
mask. She's a beautiful hip-hop college professor with only herself to blame.
They fight crime!
--
nautilus-list mailing list
[email protected]
http://mail.gnome.org/mailman/listinfo/nautilus-list
