On Thu, 2006-02-23 at 20:31 -0600, Federico Mena Quintero wrote:
> Hi,
>
> My patch from http://bugzilla.gnome.org/show_bug.cgi?id=45953#c32 was
> incorrect. This was to fix the case where you
>
> 1. insert a CD or other removable media
>
> 2. the media already had position metadata
>
> 3. but there's another icon in the desktop in that position
>
> 4. so you get an overlap
>
> It turns out that my patch *didn't* work if there was no metadata to
> begin with, i.e. for a new user, or for media with a totally new display
> name. The new icon would end up in both the semi_position_icons and
> no_position_icons lists (ugh!).
>
> The attached patch fixes this with very simple logic:
>
> if (has_position_metadata (icon)) {
> if (no_auto_layout && icon.has_lazy_position)) {
> semi_position_icons += icon;
> }
> } else {
> no_position_icons += icon;
> }
>
> Also, this patch fixes another bug when snapping new icons to the grid.
> Icons could get placed with the icon image at x=0. The ChangeLog
> describes when this could happen.
This looks good to me, so I'm commiting it (to get it into todays
release).
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
Alexander Larsson Red Hat, Inc
[EMAIL PROTECTED] [EMAIL PROTECTED]
He's a genetically engineered native American librarian on his last day in the
job. She's a green-fingered motormouth lawyer who dreams of becoming Elvis.
They fight crime!
--
nautilus-list mailing list
[email protected]
http://mail.gnome.org/mailman/listinfo/nautilus-list
