This is really cool, well done. Any numbers about the improvements?? any comparison? I guess this optimization is best appreciated when there are lots of files in a directory.
Cheers, -William El vie, 24-02-2006 a las 10:30 +0100, Alexander Larsson escribió: > I just realised that when calculating the "size" calculation for folders > (the number of items in the folder) we're currently getting all > information from the files in that folder (i.e. a stat call per file) > when we only really need the filenames. > > The two attached patches avoids this, and testing with strace shows that > before applying we stat each file in a subdirectory of the displayed > file, whereas after we only do a readdir of each subdirectory. Of > course, this is only done if the size is shown in the view (optional in > icon view, always in list view). > > Unfortunately the gnome-vfs patch adds a piece of API. Should we try to > get this into gnome 2.14? Opinions? > > =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= > Alexander Larsson Red Hat, Inc > [EMAIL PROTECTED] [EMAIL PROTECTED] > He's a benighted hunchbacked jungle king from a doomed world. She's a > beautiful streetsmart research scientist descended from a line of powerful > witches. They fight crime! > -- > nautilus-list mailing list > [email protected] > http://mail.gnome.org/mailman/listinfo/nautilus-list -- nautilus-list mailing list [email protected] http://mail.gnome.org/mailman/listinfo/nautilus-list
