On Wed, 2006-03-29 at 22:33 +0200, martin wehner wrote: > On 3/27/06, Philip Van Hoof <[EMAIL PROTECTED]> wrote:
Hey Martin, Thanks for the review. > > You can find a patch attached to this bug that will replace the popt > > stuff with the newer GOption API: > > > > http://bugzilla.gnome.org/show_bug.cgi?id=336065 > > Thanks - it looks good in general, but there's a new string in there > ("[URI...]"), so we can't commit it for gnome-2.14 in its current form > (and we haven't branched yet). There's also a combined > declaration/initialization (**remaining), which is styleguide > violation. > For the context name we'd probably want something with newlines at the > start as the documentation suggests, so that it shows up in a new > line. The description from the desktop file would be appropriate I > think. Is it okay (for me) to append this as a comment to the bug? That's more easy for me to track it. I'll probably adapt the patch soon. But feel free (if nautilus would be or is in a hurry) to go ahead of course. I'd say, in that case: keep the bug updated so that we aren't duplicating work ;-) > Btw, nautilus-connect-server-dialog does use popt too now, so if you > feel inclined to completely purge it from nautilus... I'll take a look at it, soon. -- Philip Van Hoof, software developer at x-tend home: me at pvanhoof dot be gnome: pvanhoof at gnome dot org work: vanhoof at x-tend dot be http://www.pvanhoof.be - http://www.x-tend.be -- nautilus-list mailing list [email protected] http://mail.gnome.org/mailman/listinfo/nautilus-list
