On Fri, 2006-06-16 at 13:53 +0200, RUAUDEL Frédéric wrote:
> Hi again,
> 
> The new patch proposal is available in bugzilla :
> 
> http://bugzilla.gnome.org/show_bug.cgi?id=339273
> 
> Indeed, the use of the NautilusSignaller API is much cleaner and require 
> less code :)

Looks much better. However, I'd prefer if this part:

+       /* Update window's current selection popup menu */
+       fm_directory_view_update_menus 
(FM_DIRECTORY_VIEW(window->content_view));

Was actually done by FMDirectoryView (by also listening to the signal).
We don't really guarantee that window->content_view is a FMDirectoryView
(although it always is right now).

=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
                   [EMAIL PROTECTED]    [EMAIL PROTECTED] 
He's a one-legged vegetarian rock star with a passion for fast cars. She's a 
radical goth archaeologist with a knack for trouble. They fight crime! 

-- 
nautilus-list mailing list
[email protected]
http://mail.gnome.org/mailman/listinfo/nautilus-list

Reply via email to