http://cvs.sourceforge.net/viewcvs.py/naviserver/naviserver/nslog/nslog.c?rev=1.3&view=log
The cvs commit message for nslog/nslog.c now reads: "Add Ns_ConnSetResponseStatus command to be able to se response status without touching headers. Also ns_conn status has been extended with ability to set response status if third argument is provided. ns_conn status ?newStatus?" Which will thoroughly confuse someone in the future. Please be careful about combining changes in a single commit. On Thu, 03 Mar 2005 10:08:33 -0500, Vlad Seryakov <[EMAIL PROTECTED]> wrote: > I've been using that new module for so long time that i did not realized > that the code is so different than > current style, i am sorry. > > > The log message doesn't say what has changed, just that something has > > changed, although the ChangeLog entry is better. The X-Forwarded-For > > change is a bug fix and is not mentioned in either. I thought we'd > > already agreed that non-trivial changes should have an RFE or BUG > > posted to the tracker? > > No, i did not add anythig new, X-Forwarded-For was handled by old nslog > as well, > i just restructure the module to support more options > > > It's unreasonable to expect end users to examine the source code for > > documentation, so we should not clutter up the code with it. There > > are no other source files I'm aware of which do this. > > nslog used to have index.html, in the CVS i do not see it, so i put the > docs in the nslog.c for now and > we do not have docs for modules yet. > > > > The members of the Log struct have been re-arranged. Variable > > declarations beginning a function have moved around. Many of the > > comments have been reformatted. Correctly formatted code has had > > braces and spacing removed, etc. This all makes it very tricky to > > read diffs to figure out what has logically changed. > > > Yes, that's my fault, i will change it to follow naviserver code style.
