On 6/10/05, Zoran Vasiljevic <[EMAIL PROTECTED]> wrote: > > Am 10.06.2005 um 08:21 schrieb Stephen Deasey: > > > On 6/9/05, Vlad Seryakov <[EMAIL PROTECTED]> wrote: > > > >> HAVE_TM_GMTOFF is not defined in the config.h.in > >> so it never gets to config.h > >> > > > > > > Ah, thanks. I've added the right call in the configure script to make > > this happen. > > Still some things left: > > dsprintf.c: In function `Ns_DStringVPrintf': > dsprintf.c:294: warning: use of `long double' type; its size may > change in a future release > dsprintf.c:294: warning: (Long double usage is reported only once for > each file. > dsprintf.c:294: warning: To disable this warning, use -Wno-long-double.) > > What should we do about that?
Has this always been a warning on Darwin? I don't see any LONGDBL mentioned in the Tcl source... > return.c: In function `Ns_ConnConstructHeaders': > return.c:262: warning: suggest parentheses around && within || > return.c: At top level: > > This is here for the long time. I think it is the time to > get rid of it. I looked there but am not sure. I cleaned up some warnings a while ago but left this one as there's a better solution in AOLserver HEAD, but it requires a few extra new functions which I didn't want to add just for a clean-up. > tclxkeylist.c: In function `Tcl_GetKeyedListKeys': > tclxkeylist.c:285: warning: passing arg 2 of `Tcl_GetStringFromObj' > from incompatible pointer type > tclxkeylist.c:293: warning: passing arg 2 of `Tcl_GetStringFromObj' > from incompatible pointer type > tclxkeylist.c: In function `Tcl_GetKeyedListField': > tclxkeylist.c:353: warning: passing arg 2 of `Tcl_GetStringFromObj' > from incompatible pointer type > tclxkeylist.c: In function `Tcl_SetKeyedListField': > tclxkeylist.c:407: warning: passing arg 2 of `Tcl_GetStringFromObj' > from incompatible pointer type > tclxkeylist.c: In function `Tcl_DeleteKeyedListField': > tclxkeylist.c:453: warning: passing arg 2 of `Tcl_GetStringFromObj' > from incompatible pointer type > tclxkeylist.c: At top level: > > This should be easy. I will take care of that. > > Stepen, you mentioned usage of some macro to get rid of the > > nsdb.c:36: warning: `RCSID' defined but not used > > type of warnings. I suppose you'd have to go wholesale change all > files, right? Yes, that's the RFE I posted recently. I wasn't going to add that until after this release, but we've started churning the code again so might as well add this now I suppose. As far as I remember, adding some of the extra checks such as for printf format strings turns up some genuine bugs. Maybe we should go for those now too? > Anyways, it compiles now on Darwin. Not very clean though: > > ld: warning prebinding disabled because (__TEXT segment (address = > 0x0 size = 0x63000) of libnsd.dylib overlaps with __TEXT segment > (address = 0x0 size = 0x6000) of /usr/local/ns/lib/libnsthread.dylib > ld: warning prebinding disabled because (__TEXT segment (address = > 0x0 size = 0x63000) of libnsd.dylib overlaps with __DATA segment > (address = 0x6000 size = 0x1000) of /usr/local/ns/lib/libnsthread.dylib > ld: warning prebinding disabled because (__TEXT segment (address = > 0x0 size = 0x63000) of libnsd.dylib overlaps with __LINKEDIT segment > (address = 0x7000 size = 0xd000) of /usr/local/ns/lib/libnsthread.dylib > > but I will have to see why. The tcl.m4 has the "-prebind" option to > linker > and I'd have to check if this is really needed. If this is a bug you should also file it with the Tcl project as this is the tcl.m4 used by all Tcl packages.
