Yes, it makes sense
Zoran Vasiljevic wrote:
Am 06.01.2006 um 19:00 schrieb Vlad Seryakov:
sockPtr will be queued into the connection queue for processing, it
may happen from driver thread or from spooler thread, works equally.
Hmhmhmhmhmhmhm...
The SOCK_SPOOL is only retured from SockRead(). The SockRead()
is only attempted in the DriverThread if :
if (sockPtr->drvPtr->opts & NS_DRIVER_ASYNC) {
n = SockRead(sockPtr, 1);
} else {
n = SOCK_READY;
}
So, the same test as above in SpoolThread has no meaning at all
since you will never come to SpoolThread unless somebody
(driver thread) calls SockRead which MAY return SOCK_SPOOL.
Do I see this right?
I'm not nitpicking! I'm just trying to understand the code.
I believe this thing could be misleading and you should
(if I'm correct) remove the above snippet from the SpoolThread
and just write:
n = SockRead(sockPtr, 1);
Zoran
-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log
files
for problems? Stop! Download the new AJAX search engine that makes
searching your log files as easy as surfing the web. DOWNLOAD SPLUNK!
http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click
_______________________________________________
naviserver-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/naviserver-devel
--
Vlad Seryakov
571 262-8608 office
[EMAIL PROTECTED]
http://www.crystalballinc.com/vlad/
