1.Macros are defined. 2. What is not accepted is the starting with multiple format strings, e.g. ""%d %d %d %" <- 1st string PRId64 <- 2nd string " %" <--- and so on
-----Original Message----- From: Gustaf Neumann [mailto:neum...@wu.ac.at] Sent: 17 October 2012 14:06 To: naviserver-devel@lists.sourceforge.net Subject: Re: [naviserver-devel] [AOLSERVER] Naviserver Win-64 Sources On 17.10.12 12:35, Maurizio Martignano wrote: > > +#ifdef _WIN64 > + Ns_DStringPrintf(dsPtr, "%d %d %d %l64d %l64d %l64d > %l64d", > +#else > Ns_DStringPrintf(dsPtr, "%d %d %d %" PRId64 " %" > PRId64 " %" PRId64 " %" PRId64, > +#endif > > > question arise: is this just _WIN64 or as well _WIN32? > Why not define PRId64 correctly for _WIN64? (and _WIN32?) > > [MM] Because the PRId64 thing works with gcc and not with Visual > Studio (or to be correct I did not manage to make it work). I believe > it works if you use MinGW, so this is why I used only _WIN64 "PRId64" has nothing to do with gcc, it is supposed to be defined by inttypes.h. From googling around it seems that these macros are often a problem with visual c, not only a problem for _WIN64. From your changes, i deduce, that PRId64 and PRIuMAX are not defined for your platform, but PRIu64 seems to be there (at least, you did not change this). Please check, if the following change fixes the issues with the PRI* macros under your platform https://bitbucket.org/naviserver/naviserver/changeset/92877ff5b9625aac023c91 1dcd862894cfd441ce > Or, why have you commented out certain code (a) for win64 and (b) for > all platforms which is certain useful: > > #ifdef NS_NOCOMPAT > -# error "No compatibility macros at present" > +// # error "No compatibility macros at present" > #endif > > This is my error, sorry, should be under _WIN64 > > ... Is anybody aware about NS_NOCOMPAT ? This seem to stem from the win32 project files. Can this be removed? > > #ifdef HAVE_TCL_GETMEMORYINFO > - Tcl_GetMemoryInfo(&ds); > - Tcl_DStringResult(interp, &ds); > + // Tcl_GetMemoryInfo(&ds); > + // Tcl_DStringResult(interp, &ds); > #endif > return TCL_OK; > > same as above under _WIN64 Why is this a problem with _WIN64? -gustaf neumann ---------------------------------------------------------------------------- -- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_sfd2d_oct _______________________________________________ naviserver-devel mailing list naviserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/naviserver-devel ------------------------------------------------------------------------------ Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_sfd2d_oct _______________________________________________ naviserver-devel mailing list naviserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/naviserver-devel
