Dear Oleg,

many thanks for these fixes, all look good, everything
is still fine on my test setups. i've already applied these on bitbucket.

@Andrew: please check these as well with your setup.

One question though: is the trick with '--data @- << $string' really the recommended
way to pass utf-8 data in windows?

all the best
-g

On 28.08.20 11:27, oleg wrote:
Hello.

A few words about the latest version of Naviserver on Windows.

Current Makefile.win32 worked fine (32-bit with Tcl 8.6).

Some minor fixes were required in the source code (attached
naviserver-win32.diff):
     * include\Makefile.win32 - fix syntax error when NAVISERVER is
       defined (expression without quotes),
     * nsd\Makefile - move file dependencies below Makefile.build
       include, nmake only creates first dependency,
     * nsd\nswin32.c - nsconf.config should be renamed to
       nfconf.configFile in accordance with the nsd.h change,
     * tests\all.tcl - add 'encoding system utf-8' at the beginning to
       for satisfy encoding.test on non-utf8 consoles,
     * tests\http.test (http-5.3b,http-9.1) - replace 'curl --data
       $string' by 'curl --data @- << $string' to preserve utf-8 data.

Also, I have included zlib from the tcl 8.6 source tree. See attached
nsd-Makefile.win32 - small hack to the source tree, simply save as
nsd\Makefile.win32 and rebuild nsd/libnsd. Note hardcoded path to zlib
sources.

The test suite completed with the following result (ns_proxy.test
skipped)

all.tcl:        Total   1542    Passed  1496
Skipped 28      Failed  18 Sourced 69 Test Files.

Thanks for the great job!

Regards
Oleg.


_______________________________________________
naviserver-devel mailing list
naviserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/naviserver-devel
_______________________________________________
naviserver-devel mailing list
naviserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/naviserver-devel

Reply via email to