On 04.09.20 13:53, oleg wrote:
After the patch, ns_http became similar to ns_return: understands charset and
-binary )
exactly.
Zoran:
> OK. I see no problem with that
I've added the "-binary" flag to "ns_http" as provided by Oleg to
bitbucket. I've also added a short documentation and the
ns_http_charsets.test, where i've added a "-binary" flag all occurrences
where "encoding convertfrom" is explicitly used (either we provide an
automatic conversion or none).
I did not have time yet to dig into TCLHTTP_USE_EXTERNALTOUTF the other
test cases depending on that. My gut feeling says "this is necessary",
but my brain says "why this was no problem so far" and "what will be the
collateral damage" if we do so.
The flag TCLHTTP_USE_EXTERNALTOUTF is still in the code but needs
further investigation. However, i am going mid of next week on holiday
(boat), where i will not be reachable ... until then many things are
piled up on my side, so i have no chance to look into this deeper right now.
The change form oleg has high quality, including many test cases which
are releated to TCLHTTP_USE_EXTERNALTOUTF but not committed yet.
all the best, and many thanks to Oleg!
-g
_______________________________________________
naviserver-devel mailing list
naviserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/naviserver-devel
