Thank you Gustaf for all your incredible work. Regarding the commands you wish to deprecate, I see that we are still using ns_formvalueput in some very old, but still used, code.
All the best Brian ________________________________ From: Gustaf Neumann (sslmail) <neum...@wu.ac.at> Sent: Friday 22 November 2024 10:19 am To: naviserver-devel@lists.sourceforge.net <naviserver-devel@lists.sourceforge.net> Subject: Re: [naviserver-devel] ns_set reform Dear all, >From the previously state goals: > 1) all commands tested in the regression test should be documented > 2) all documented commands should be tested (at least syntax-tested) > 3) all implemented commands should be tested > 4) the parameters of the implemented commands should be documented and vice > versa. > 5) deprecated commands should be listed in the deprecated section of the > command listing in the documentation, but not advertised in the documentation At least 1 and 2 are finished by today. This week, i have added over 700 tests to the regression test, which was hard work and took all my resources. We have now 2608 tests in the NaviServer 5 regression test vs. 1893 in the newest 4.99 branch: % egrep -r --include=*.test '^test ' /usr/local/src/naviserver/ |wc -l 2608 % egrep -r --include=*.test '^test ' /usr/local/src/naviserver-4.99/ |wc -l 1893 The current state is not perfect, but a progress. Tested commands not documented ------------> 706 tested commands, 72 deprecated, 648 documented, 0 NOT documented Documented commands not tested ------------> 648 documented commands, 648 tested, 0 NOT tested Deprecated commands which are documented ------------> 0 deprecated commands are documented The next goal is to check the alignment of the argument lists of the implementation with the documentation. On my wishlist is also a non-deprecated mode switchable via configuration file, where NaviServer offers only non-deprecated commands. In the meanwhile, something to think about for you: We have still a bunch of commands, which have a questionable future. These commands are in a "TBD" state for 19 years. I think, we should deprecate these commands (see below for the list) in the NaviServer 5 release. Please speak up, if your applications need these: ns_browsermatch ns_choosecharset ns_cookiecharset ns_formfieldcharset ns_formvalueput ns_paren ns_tagelement ns_tagelementset All the best -g
_______________________________________________ naviserver-devel mailing list naviserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/naviserver-devel