On Sat, May 28, 2011 at 06:24:28AM +0100, Alex Bligh wrote: > Again, only tested with "make check", but I don't think we test > oversize writes (we probably should do in the oversize test).
The oversize does check oversized writes, but it doesn't do more than 'check whether the server returns something', in the way of the throughput test. It would be a good idea to check the handle, indeed. The tests are pretty basic. They're better than nothing, but I am very much aware that their coverage is... minimal. Your 'integrity' test has just ramped up the coverage by a gazillion, which is great. Thanks for that. It's just that I wouldn't be surprised if I were to find out that you're already the most prolific contributor (other than me) to nbd userland ever since I took over maintainership, if you see my problem... -- The volume of a pizza of thickness a and radius z can be described by the following formula: pi zz a ------------------------------------------------------------------------------ vRanger cuts backup time in half-while increasing security. With the market-leading solution for virtual backup and recovery, you get blazing-fast, flexible, and affordable data protection. Download your free trial now. http://p.sf.net/sfu/quest-d2dcopy1 _______________________________________________ Nbd-general mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/nbd-general
