On Fri, Sep 16, 2011 at 10:26:09AM +0200, Wouter Verhelst wrote: > Hi, > > So yesterday I implemented the fallocate(FALLOC_FL_PUNCH_HOLE) stuff for > NBD_CMD_TRIM. It's compile-tested, but not yet functionally tested. To > be honest, I'm not entirely sure how to test whether a file is sparse in > a particular region; anyone? > > Anyway, reviews on that short piece of code are obviously welcome.
After looking at it myself, I already find two issues: - Need to deal with copy-on-write - Need to have better error handling. Scratch that, make that "need to have error handling", period. -- The volume of a pizza of thickness a and radius z can be described by the following formula: pi zz a ------------------------------------------------------------------------------ BlackBerry® DevCon Americas, Oct. 18-20, San Francisco, CA http://p.sf.net/sfu/rim-devcon-copy2 _______________________________________________ Nbd-general mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/nbd-general
