> >> > > Am I right that discard/trim is in kernel 3.9? Or is it already in 3.8? > >> > Patch was merged into Linus's tree on 5Oct12, so it should have made 3.7. > >> > >> There are problems with it, it seems. > > Doesn't seem to be anything related to trim/discard. Does your kernel > have the kill_bdev calls in nbd? Look for:
> @@ -627,6 +635,7 @@ static int __nbd_ioctl(struct block_devi > nbd_clear_que(nbd); > BUG_ON(!list_empty(&nbd->queue_head)); > BUG_ON(!list_empty(&nbd->waiting_queue)); > + kill_bdev(bdev); > if (file) > fput(file); > return 0; > @@ -719,6 +728,7 @@ static int __nbd_ioctl(struct block_devi > nbd->file = NULL; > nbd_clear_que(nbd); > dev_warn(disk_to_dev(nbd->disk), "queue cleared\n"); > + kill_bdev(bdev); > queue_flag_clear_unlocked(QUEUE_FLAG_DISCARD, > nbd->disk->queue); > if (file) > fput(file); Yes: belle:/usr/src/linux-3.8.3/drivers/block# grep -n -C 3 kill_bdev nbd.c 622- nbd_clear_que(nbd); 623- BUG_ON(!list_empty(&nbd->queue_head)); 624- BUG_ON(!list_empty(&nbd->waiting_queue)); 625: kill_bdev(bdev); 626- if (file) 627- fput(file); 628- return 0; -- 711- nbd->file = NULL; 712- nbd_clear_que(nbd); 713- dev_warn(disk_to_dev(nbd->disk), "queue cleared\n"); 714: kill_bdev(bdev); 715- queue_flag_clear_unlocked(QUEUE_FLAG_DISCARD, nbd->disk->queue); 716- if (file) 717- fput(file); Folkert van Heusden -- Multitail es una herramienta flexible que permite visualizar los "log file" y seguir la ejecución de comandos. Permite filtrar, añadir colores, combinar archivos, la visualización de diferencias (diff- view), etc. http://www.vanheusden.com/multitail/ ---------------------------------------------------------------------- Phone: +31-6-41278122, PGP-key: 1F28D8AE, www.vanheusden.com ------------------------------------------------------------------------------ Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_mar _______________________________________________ Nbd-general mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/nbd-general
