From: Pavel Borzenkov <[email protected]> It is unclear what the behaviour of a server should be if it receives an unknown command. Similar uncertainty exists for command flags.
Make it explicit that the server should return EINVAL in all such cases. Signed-off-by: Pavel Borzenkov <[email protected]> Reviewed-by: Roman Kagan <[email protected]> Signed-off-by: Denis V. Lunev <[email protected]> CC: Wouter Verhelst <[email protected]> CC: Eric Blake <[email protected]> CC: Alex Bligh <[email protected]> --- doc/proto.md | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/doc/proto.md b/doc/proto.md index d54ed19..036d6d9 100644 --- a/doc/proto.md +++ b/doc/proto.md @@ -512,6 +512,13 @@ return `EINVAL` if it receives a read or trim request including one or more sectors beyond the size of the device. It also SHOULD map the `EDQUOT` and `EFBIG` errors to `ENOSPC`. Finally, it SHOULD return `EPERM` if it receives a write or trim request on a read-only export. + +The server SHOULD return `EINVAL` if it receives an unknown command. + +The server SHOULD return `EINVAL` if it receives an unknown command flag. It +also SHOULD return `EINVAL` if it receives a request with a flag not explicitly +documented as applicable to the given request. + Which error to return in any other case is not specified by the NBD protocol. -- 2.1.4 ------------------------------------------------------------------------------ Transform Data into Opportunity. Accelerate data analysis in your applications with Intel Data Analytics Acceleration Library. Click to learn more. http://pubads.g.doubleclick.net/gampad/clk?id=278785471&iu=/4140 _______________________________________________ Nbd-general mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/nbd-general
