On 04/07/2016 03:43 AM, Alex Bligh wrote: > Eric, Wouter, > > I put together a note for my own memory on where I think the various patches > to doc/proto.md (and related code patch(es)) circulating over the last few > days are. > > I think "[PATCHv5] docs/proto.md: Clarify SHOULD / MUST / MAY etc" > is probably ready to merge now. Wouter's points were all addressed > in v5, and Eric OK'd v5 apart from some issues re NBD_OPT_GO that > weren't actually introduced by the patch.
Agreed. I can supply the followup for NBD_OPT_GO, if you'd like. > > Merged > ====== > > EB: [Nbd] [PATCH] doc: Revert swap of NBD_REP_SERVER fields in NBD_OPT_GO > AB: [Nbd] [PATCHv3] Document format of strings in one place, limit to 4096 > bytes > EB: [Nbd] [PATCH] doc: Wording cleanups > EB: [Nbd] [PATCH] Don't error on NBD_FLAG_CMD_FUA on non-writes > AB: [Nbd] [PATCH] doc/proto.md: NBD_OPT_STARTTLS cannot be used twice > AB: [Nbd] [PATCHv5] Improve the documentation of NBD_CMD_FLUSH and > NBD_CMD_FLAG_FUA. > AB: [Nbd] [PATCH] Amend NBD_OPT_SELECT and NBD_OPT_GO documentation > > In discussion > ============= > > AB: [Nbd] [PATCHv5] docs/proto.md: Clarify SHOULD / MUST / MAY etc > EB: [Nbd] [PATCH v2] doc: Add NBD_CMD_BLOCK_STATUS extension Discussion includes the ability to limit the commands' output, whether from the client or from the server; whether to pick a single format that lets dirtiness be exposed without a flag. I suspect that a proof-of-concept implementation for qemu's needs may be necessary before this one can be finalized. > EB: [Nbd] [PATCH v2] doc: Allow NBD_CMD_FLAG_NO_HOLE during NBD_CMD_WRITE Discussion includes that it may be better to add a new NBD_OPT_ for communicating client preference for default server behavior, rather than the client having to set the flag on every WRITE. This one should be easier to come up with v3 than BLOCK_STATUS. > > Yet to write patch / proposal > ============================= > > AB: [Nbd] NBD_CMD_SAFE_DISC > AB: [Nbd] doc/proto.md: TLS question EB: NBD_OPT_GO cleanup mentioned above EB: extension to allow server to advertise min/preferred/max sizing > > Others > ====== > > [Nbd] Maximum error message length? - superseded by merged [PATCHv3] Document > format of strings in one place, limit to 4096 bytes > -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
------------------------------------------------------------------------------
_______________________________________________ Nbd-general mailing list Nbd-general@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nbd-general
