On 04/19/2016 01:34 AM, Alex Bligh wrote: > Eric, > > Thanks. Applied. > > I've reserved NBD_REP_ERR_BLOCK_SIZE_REQD in master, but in future > it would be best if when applying a patch to a branch that > requires a reservation in master, a patch for master was > supplied too.
Sure, I don't mind the extra work. Any thoughts about my other question? >> Question: Should we rearrange the various errors, so that >> NBD_REP_ERR_UNKNOWN and NBD_REP_ERR_BLOCK_SIZE_REQD are >> adjacent (since they are, for now, in the same extension >> branch), by hoising NBD_REP_ERR_SHUTDOWN to 2^32 + 6? We >> don't yet have any released versions that use >> NBD_REP_ERR_SHUTDOWN, although it was added as normative text >> without going through the usual extension work. Likewise for putting NBD_OPT_BLOCK_SIZE adjacent to NBD_OPT_GO if we keep block sizes as part of the INFO extension rather than its own. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
------------------------------------------------------------------------------ Find and fix application performance issues faster with Applications Manager Applications Manager provides deep performance insights into multiple tiers of your business applications. It resolves application problems quickly and reduces your MTTR. Get your free trial! https://ad.doubleclick.net/ddm/clk/302982198;130105516;z
_______________________________________________ Nbd-general mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/nbd-general
