On Tue, May 23, 2017 at 04:27:56PM +0200, Ilya Dryomov wrote: > On Tue, May 23, 2017 at 4:16 PM, Jens Axboe <ax...@fb.com> wrote: > > On 05/23/2017 08:14 AM, Josef Bacik wrote: > >> On Tue, May 23, 2017 at 12:38:31PM +0200, Ilya Dryomov wrote: > >>> nbd_config is allocated in nbd_alloc_config(), but never freed. > >>> > >>> Fixes: 5ea8d10802ec ("nbd: separate out the config information") > >>> Signed-off-by: Ilya Dryomov <idryo...@gmail.com> > >>> --- > >>> drivers/block/nbd.c | 1 + > >>> 1 file changed, 1 insertion(+) > >>> > >> > >> Oops, thanks Ilya > >> > >> Reviewed-by: Josef Bacik <jba...@fb.com> > > > > Since config is referenced, why isn't this done in nbd_config_put() > > instead? > > Josef's 5ea8d10802ec added that nbd->config = NULL to nbd_reset(), so > I followed his lead. It could be done nbd_config_put() -- nbd_reset() > call in nbd_dev_add() looks like a no-op to me. Josef? >
Yeah it used to be called more, but when I moved the config to be ref counted it lost it's old uses and I just didn't notice enough to delete it. Just fold that into nbd_config_put() and call it a day. Thanks, Josef ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Nbd-general mailing list Nbd-general@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nbd-general