Good enough for me. :) I need to do some refactoring to remove a few methods that are no longer needed and to remove any Java 1.5 features that are in there.
Thanks for your help, Marty On Wed, Oct 7, 2009 at 6:25 AM, Tom Schindl <[email protected]> wrote: > Keep it as small as possible so I'd expose the Table-Class. > > Tom > > Marty Jones schrieb: > > Tom, > > > > Thanks for the input. I have the TableCombo now separated into a SWT > > TableCombo class and a JFace TableComboViewer class. > > > > Both implementations are working but I am not comfortable with having > > the TableCombo class expose it's Table reference as public so that the > > SWT version can create new TableItem rows and the JFace version to be > > able to create new TableItem's as well. > > > > I thought about wrapping the TableItem object and just creating a new > > TableItem when the new WrapperTableItem is created but that seems like > > overkill. Do you have a opinion as to whether or not the Table > > reference is ok being public or do you think I should find a solution > > where the Table reference is not exposed? > > > > Marty > > > > On Wed, Oct 7, 2009 at 4:04 AM, Tom Schindl <[email protected] > > <mailto:[email protected]>> wrote: > > > > Hi Marty, > > > > The less the better but we also allow widgets to use Java5 if they > > really need it but Java5 is the maximum because there are still a lot > of > > users (especially on OS-X who don't use Java6). > > > > So if there's a real benefit for the user than use Java5 else stick > to > > JDK 1.4 or even better 1.3 :-) > > > > Tom > > > > Marty Jones schrieb: > > > I have a couple of questions. > > > > > > What version of the JDK should I code the widget against? > > > > > > Can we use Generics or the enhanced for loop? > > > > > > What about using Lists instead of arrays? > > > > > > Is there any guidelines to what JDK features you should not use? > > > > > > > > > Thanks, > > > > > > Marty > > > > > > > > > On Tue, Oct 6, 2009 at 10:53 AM, Tom Schindl > > <[email protected] <mailto:[email protected]> > > > <mailto:[email protected] <mailto:[email protected]>>> > > wrote: > > > > > > Hi, > > > > > > Yes but take a look at the CTreeCombo sources (they never got > > part of > > > Nebula because I'm lacking time to maintain one more thing). > > > > > > The sources are here: > > > > > > http://publicsvn.bestsolution.at/repos/java/examples/EMF-Databinding/at.bestsolution.soccer.ui.common/src/at/bestsolution/soccer/ui/common/widgets/ > > > > > > http://publicsvn.bestsolution.at/repos/java/examples/EMF-Databinding/at.bestsolution.soccer.ui.common/src/at/bestsolution/soccer/ui/common/viewers/ > > > > > > I'm going to file a CQ later and for your bug and you can do > the > > > refactoring probably inside Nebula. > > > > > > Tom > > > > > > Marty Jones schrieb: > > > > Gotcha. I will take a look at the Grid and RadioGroup > > widgets to see > > > > how they are configured to use optional dependencies. > > > > > > > > Do you guys think that if I can get my widget to work under > > > straight SWT > > > > as well as JFace that it would qualify to be added as a > > Nebula widget? > > > > > > > > On Tue, Oct 6, 2009 at 10:28 AM, Tom Schindl > > > <[email protected] <mailto:[email protected]> > > <mailto:[email protected] <mailto:[email protected]>> > > > > <mailto:[email protected] > > <mailto:[email protected]> <mailto:[email protected] > > <mailto:[email protected]>>>> > > > wrote: > > > > > > > > Hi Marty, > > > > > > > > I don't think we want different bundles but one bundle > > with an > > > optional > > > > dependency but didn't set up extra rules for this (at > > least the > > > > Nebula-Grid does it this way and the RadioGroup-Widget > > as well). > > > > > > > > Tom > > > > > > > > Marty Jones schrieb: > > > > > Emil, > > > > > > > > > > I am going to see if I can separate out the JFace > version > > > and create > > > > > a straight SWT module as well. Do you have any > > examples of > > > where this > > > > > was done with one of the Nebula Widgets? I am trying > > to find a > > > > example > > > > > of how this has been done in the past. > > > > > > > > > > Marty > > > > > > > > > > On Tue, Oct 6, 2009 at 2:55 AM, Emil Crumhorn > > > > <[email protected] > > <mailto:[email protected]> <mailto:[email protected] > > <mailto:[email protected]>> > > > <mailto:[email protected] > > <mailto:[email protected]> <mailto:[email protected] > > <mailto:[email protected]>>> > > > > > <mailto:[email protected] > > <mailto:[email protected]> > > > <mailto:[email protected] > > <mailto:[email protected]>> <mailto:[email protected] > > <mailto:[email protected]> > > > <mailto:[email protected] > > <mailto:[email protected]>>>>> > > > > wrote: > > > > > > > > > > Nice widget! I really like it. I see it depends on; > > > > > > > > > > org.eclipse.core.commands > > > > > org.eclipse.equinox.common > > > > > > > > > > and also JFace > > > > > > > > > > I'm not sure of the [current] policy of widgets in > > > Nebula, but it > > > > > used to be "pure SWT" and any JFace stuff had to > > be put as a > > > > > separate "module" of the "core" as an option to > those > > > that want to > > > > > use JFace. > > > > > > > > > > Perhaps it's time to drop those rules, but, > > thought I'd > > > point it > > > > > out. Perhaps that can be worked around or are those > > > dependencies > > > > > critical (from a quick look it seems it's mostly > > the label > > > > providers > > > > > and intra-dependencies from JFace)? > > > > > > > > > > Cheers, > > > > > Emil > > > > > > > > > > > > > > > > > > > > On Tue, Oct 6, 2009 at 1:37 AM, Marty Jones > > > > <[email protected] <mailto:[email protected]> > > <mailto:[email protected] <mailto:[email protected]>> > > > <mailto:[email protected] <mailto:[email protected]> > > <mailto:[email protected] <mailto:[email protected]>>> > > > > > <mailto:[email protected] > > <mailto:[email protected]> > > > <mailto:[email protected] <mailto:[email protected]>> > > <mailto:[email protected] <mailto:[email protected]> > > > <mailto:[email protected] <mailto:[email protected] > >>>>> > > > > wrote: > > > > > > > > > > Chris, > > > > > > > > > > I have filed a bug with the TableCombo source > > attached ( > > > > > *Bug 291432* > > > > > > > > <https://bugs.eclipse.org/bugs/show_bug.cgi?id=291432>). I > > > > > wasn't sure which component to choose so I > > chose "Core". > > > > > > > > > > You are correct in that the license is > > "Eclipse Public > > > > License". > > > > > > > > > > Thanks, > > > > > > > > > > Marty > > > > > > > > > > > > > > > > > > > > On Mon, Oct 5, 2009 at 4:43 PM, Chris Aniszczyk > > > > > <[email protected] > > <mailto:[email protected]> <mailto:[email protected] > > <mailto:[email protected]>> > > > <mailto:[email protected] <mailto:[email protected]> > > <mailto:[email protected] <mailto:[email protected]>>> > > > > <mailto:[email protected] > > <mailto:[email protected]> <mailto:[email protected] > > <mailto:[email protected]>> > > > <mailto:[email protected] <mailto:[email protected]> > > <mailto:[email protected] <mailto:[email protected]>>>>> > wrote: > > > > > > > > > > On Mon, Oct 5, 2009 at 10:55 AM, Marty > Jones > > > > > <[email protected] > > <mailto:[email protected]> > > > <mailto:[email protected] <mailto:[email protected]>> > > <mailto:[email protected] <mailto:[email protected]> > > > <mailto:[email protected] <mailto:[email protected]>>> > > > > <mailto:[email protected] > > <mailto:[email protected]> <mailto:[email protected] > > <mailto:[email protected]>> > > > <mailto:[email protected] <mailto:[email protected]> > > <mailto:[email protected] <mailto:[email protected]>>>>> > wrote: > > > > > > > > > > Hello, > > > > > > > > > > My name is Marty Jones and I have > > created a > > > widget > > > > that > > > > > I call a TableCombo. This widget is > based > > > upon the > > > > > CCombo widget but uses a Table for the > > drop down > > > > portion > > > > > of the combo instead of a List. > > > > > > > > > > My widget has the following features: > > > > > > > > > > o Supports displaying multiple > > columns of > > > > data in > > > > > the drop down portion of the combo. > > > > > o Supports displaying a header > > for the > > > drop down > > > > > portion of the combo. > > > > > o Supports images for each > > column that is > > > > > displayed within the drop down portion > of > > > the combo. > > > > > o Supports custom Colors and > > Fonts for > > > each > > > > Row & > > > > > Column within the drop down portion of > the > > > combo. > > > > > o Supports displaying a % of the > > full > > > drop down > > > > > portion of the combo. So you can > specify > > > that the > > > > viewable > > > > > portion of the drop down > > will be > > > 75% of the > > > > > full width of the table and a > Horizontal > > > scrollbar > > > > will > > > > > be displayed. > > > > > > > > > > I would like to submit this widget as a > > > candidate > > > > widget > > > > > for the Nebula Project. > > > > > > > > > > The source code can be downloaded from > the > > > following > > > > > link: > > > www.modelsoftware.com/nebula/TableCombo.zip > > <http://www.modelsoftware.com/nebula/TableCombo.zip> > > > <http://www.modelsoftware.com/nebula/TableCombo.zip> > > > > <http://www.modelsoftware.com/nebula/TableCombo.zip> > > > > > > > > <http://www.modelsoftware.com/nebula/TableCombo.zip> > > > > > > > > > > > > > > > Very cool! > > > > > > > > > > The first step is to file a bug against > Nebula > > > and attach > > > > > the source code: > > > > > > > > > > https://bugs.eclipse.org/bugs/enter_bug.cgi?product=Nebula > > > > > > > > > > I'm assuming the code is under the Eclipse > > > Public License? > > > > > > > > > > When you file the bug, let us know. > > > > > > > > > > Cheers, > > > > > > > > > > -- > > > > > Chris Aniszczyk | EclipseSource Austin | > > +1 860 > > > 839 2465 > > > > > http://twitter.com/eclipsesource | > > > > http://twitter.com/caniszczyk > > > > > > > > > > > > _______________________________________________ > > > > > nebula-dev mailing list > > > > > [email protected] > > <mailto:[email protected]> > > > <mailto:[email protected] > > <mailto:[email protected]>> <mailto:[email protected] > > <mailto:[email protected]> > > > <mailto:[email protected] <mailto:[email protected] > >>> > > > > <mailto:[email protected] > > <mailto:[email protected]> <mailto:[email protected] > > <mailto:[email protected]>> > > > <mailto:[email protected] <mailto:[email protected]> > > <mailto:[email protected] <mailto:[email protected]>>>> > > > > > > > https://dev.eclipse.org/mailman/listinfo/nebula-dev > > > > > > > > > > > > > > > > > > > > _______________________________________________ > > > > > nebula-dev mailing list > > > > > [email protected] > > <mailto:[email protected]> > > > <mailto:[email protected] > > <mailto:[email protected]>> <mailto:[email protected] > > <mailto:[email protected]> > > > <mailto:[email protected] <mailto:[email protected] > >>> > > > > <mailto:[email protected] > > <mailto:[email protected]> <mailto:[email protected] > > <mailto:[email protected]>> > > > <mailto:[email protected] <mailto:[email protected]> > > <mailto:[email protected] <mailto:[email protected]>>>> > > > > > > > https://dev.eclipse.org/mailman/listinfo/nebula-dev > > > > > > > > > > > > > > > > > > > > _______________________________________________ > > > > > nebula-dev mailing list > > > > > [email protected] > > <mailto:[email protected]> <mailto:[email protected] > > <mailto:[email protected]>> > > > <mailto:[email protected] <mailto:[email protected]> > > <mailto:[email protected] <mailto:[email protected]>>> > > > > <mailto:[email protected] > > <mailto:[email protected]> <mailto:[email protected] > > <mailto:[email protected]>> > > > <mailto:[email protected] <mailto:[email protected]> > > <mailto:[email protected] <mailto:[email protected]>>>> > > > > > > https://dev.eclipse.org/mailman/listinfo/nebula-dev > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ------------------------------------------------------------------------ > > > > > > > > > > _______________________________________________ > > > > > nebula-dev mailing list > > > > > [email protected] <mailto:[email protected]> > > <mailto:[email protected] <mailto:[email protected]>> > > > <mailto:[email protected] <mailto:[email protected]> > > <mailto:[email protected] <mailto:[email protected]>>> > > > > > https://dev.eclipse.org/mailman/listinfo/nebula-dev > > > > > > > > _______________________________________________ > > > > nebula-dev mailing list > > > > [email protected] <mailto:[email protected]> > > <mailto:[email protected] <mailto:[email protected]>> > > > <mailto:[email protected] <mailto:[email protected]> > > <mailto:[email protected] <mailto:[email protected]>>> > > > > https://dev.eclipse.org/mailman/listinfo/nebula-dev > > > > > > > > > > > > > > > > > > > > > > ------------------------------------------------------------------------ > > > > > > > > _______________________________________________ > > > > nebula-dev mailing list > > > > [email protected] <mailto:[email protected]> > > <mailto:[email protected] <mailto:[email protected]>> > > > > https://dev.eclipse.org/mailman/listinfo/nebula-dev > > > > > > _______________________________________________ > > > nebula-dev mailing list > > > [email protected] <mailto:[email protected]> > > <mailto:[email protected] <mailto:[email protected]>> > > > https://dev.eclipse.org/mailman/listinfo/nebula-dev > > > > > > > > > > > > > > > ------------------------------------------------------------------------ > > > > > > _______________________________________________ > > > nebula-dev mailing list > > > [email protected] <mailto:[email protected]> > > > https://dev.eclipse.org/mailman/listinfo/nebula-dev > > > > _______________________________________________ > > nebula-dev mailing list > > [email protected] <mailto:[email protected]> > > https://dev.eclipse.org/mailman/listinfo/nebula-dev > > > > > > > > ------------------------------------------------------------------------ > > > > _______________________________________________ > > nebula-dev mailing list > > [email protected] > > https://dev.eclipse.org/mailman/listinfo/nebula-dev > > _______________________________________________ > nebula-dev mailing list > [email protected] > https://dev.eclipse.org/mailman/listinfo/nebula-dev >
_______________________________________________ nebula-dev mailing list [email protected] https://dev.eclipse.org/mailman/listinfo/nebula-dev
