Perfect, so I will simply provide a patch reformatting the XY widget code.
Is there any formatter you would suggest?
I see eclipse just recently changed the default formatter and increased
line length to 120 or 140 (would have to look this up).
Agreed to use the default formatter with increased line length?
br
Christian
On 21.02.2015 20:21, Wim Jongman wrote:
Hi,
Sounds great guys!
Xihui recently indicated he would not mind some help maintaining and
enhancing the visualization widgets.
I'm happy to start committer election for you two if you plan to put
some longer term effort into this.
Cheers,
Wim
On Feb 21, 2015, at 19:46, "Torkild Ulvøy Resheim" <[email protected]
<mailto:[email protected]>> wrote:
Hi Christian,
I'm not a Nebula committer, but we're consuming this widget and it's quite
important to us so I'm taking this liberty. Please correct me if I'm wrong.
21. feb. 2015 kl. 19.09 skrev Christian Pontesegger
<[email protected]
<mailto:[email protected]>>: Hi, as part of the
eclipse.org/ease <http://eclipse.org/ease> project we are
working on a scripting module for charting. Due to the
scripting nature it will allow to interactively create XY
charts. Therefore we would like to contribute some extensions
to the XYGraph widget. A first approach has been taken with
[1], adding styling to chart series, allowing to customize the
way single points of a series are rendered. I see that this
topic is already in review. Gerrit reports >2000 LOC here,
which would mean we need a CQ for this. Still most changes are
caused by a wrong code formatter. I tried to fix this with the
Eclipse built in formatter, but it is also not compliant. What
would be the suggested way to commit this change?
The XYGraph does not appear to have any project wide formatting settings,
so using the formatter on this code would most likely result in undesirable
changes. I suggest reverting those caused by the formatter.
At a later stage we are planning to commit further
improvements like an additional zoom mode, merging rubberband,
vertical and horizontal zoom modes. Further we think of adding
cursor support (not to be mixed up with markers, which are
already supported).
I'm looking forward to this :-)
If there is no formatter available we might first create a
changeset, simply reformatting affected code (using the
Eclipse built-in style?) and provide our additions afterwards.
This would help to avoid the CQ.
Yes, good idea.
[snip]
Best regards,
Torkild
_______________________________________________
nebula-dev mailing list
[email protected]
To change your delivery options, retrieve your password, or unsubscribe from
this list, visit
https://dev.eclipse.org/mailman/listinfo/nebula-dev
_______________________________________________
nebula-dev mailing list
[email protected]
To change your delivery options, retrieve your password, or unsubscribe from
this list, visit
https://dev.eclipse.org/mailman/listinfo/nebula-dev
