Okay all is pushed. Thanks Hallvard. On Thu, May 26, 2016 at 2:05 PM, Hallvard Trætteberg <[email protected]> wrote:
> Another try, now with issue # > > Overview of changes and additions: > - Refactoring into internal and external packages to better separate the > (reduced) external API from internals. Issue #384076 > - Separated the core management of tile images from the GeoMap control, so > it may be reused in e.g. Draw2D or a web service. > - A JFace viewer and Draw2D figure is supported with optional dependencies > on corresponding plugins. Issue #380072 > - Separate tests project using SWTBot. > - Introduced a GeoMapListener for tracking navigation, instead of using > PropertyChangeListener, and some internal listeners for tile management. > Issue #384079 > - Removed dependency on logging framework. Issue #384078 > - Support tool tips depending on location in JFace viewer. > - More useful zoom methods (to rectangle or set of locations) > - Changed default OSM map server. Issue #421360 > - Documentation and code cleanup > > > From: <[email protected]> on behalf of Hallvard Trætteberg < > [email protected]> > Reply-To: Nebula Dev <[email protected]> > Date: Thursday 26 May 2016 13:32 > To: Nebula Dev <[email protected]> > Subject: Re: [nebula-dev] Geomap > > Sounds OK. Here’s a summary of what the “one big commit” would cover: > > Overview of changes and additions: > - Refactoring into internal and external packages to better separate the > (reduced) external API from internals. > - Separated the core management of tile images from the GeoMap control, so > it may be reused in e.g. Draw2D or a web service. > - a JFace viewer and Draw2D figure is supported with optional dependencies > on corresponding plugins. > - Separate tests project using SWTBot. > - Introduced a GeoMapListener, covering many use cases, instead of using > PropertyChangeListener and logging. > - Support for tool tips depending on location. > - More useful zoom methods (to rectangle or set of locations) > - Documentation and code cleanup > > Hallvard > From: <[email protected]> on behalf of Wim Jongman < > [email protected]> > Reply-To: Nebula Dev <[email protected]> > Date: Thursday 26 May 2016 11:25 > To: Nebula Dev <[email protected]> > Subject: [nebula-dev] Geomap > > Hallvard I am unable to process your patches because Eclipse wont let me > push it. > > So I did a repo diff and I am going to apply all your changes in one big > commit. > > However, I don't feel comfortable with pushing this big change a few days > before the release. I am going to push the patch but I will let it cook in > incubation for a few more weeks. > > This gives us a good reason for a next release once you declare it stable. > > Do you agree?. > > Cheers, > > Wim > > > _______________________________________________ > nebula-dev mailing list > [email protected] > To change your delivery options, retrieve your password, or unsubscribe > from this list, visit > https://dev.eclipse.org/mailman/listinfo/nebula-dev >
_______________________________________________ nebula-dev mailing list [email protected] To change your delivery options, retrieve your password, or unsubscribe from this list, visit https://dev.eclipse.org/mailman/listinfo/nebula-dev
